Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): AUD-933 resolve contact ui dropdown getting cut off on small screens #1817

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix(dropdown): AUD-933 resolve contact ui dropdown getting cut off on small screens #1817

merged 2 commits into from
Oct 18, 2023

Conversation

QuintonJason
Copy link
Contributor

Description

  • Resolve dropdowns getting cut off on contact ui

Screenshots

Before After
Screenshot 2023-10-16 at 12 23 05 PM Screenshot_2023-10-16_at_12_22_54 PM

Testing in sage-lib

  • Visit the dropdown Rails page
  • Set your browser height to less than 700px tall and verify that the dropdown menu max-height is smaller

Testing in kajabi-products

  1. (MEDIUM) Reduce Dropdown menu size on smaller screens.

Related

AUDS-933

@QuintonJason QuintonJason self-assigned this Oct 16, 2023
@QuintonJason QuintonJason requested a review from a team October 16, 2023 19:26
@QuintonJason QuintonJason marked this pull request as ready for review October 16, 2023 19:26
pixelflips
pixelflips approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pixelflips pixelflips requested a review from a team October 16, 2023 20:13
@QuintonJason QuintonJason force-pushed the AUD-933/qj-contact-ui-cut-off-small-screens branch from e8bcea1 to a1ff19c Compare October 18, 2023 14:42
@QuintonJason QuintonJason merged commit 81e5011 into develop Oct 18, 2023
4 checks passed
@QuintonJason QuintonJason deleted the AUD-933/qj-contact-ui-cut-off-small-screens branch October 18, 2023 14:47
@QuintonJason QuintonJason mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

Assignees

@QuintonJason QuintonJason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @pixelflips @ju-Skinner